Skip to content

fix combination of type merging and gateway type extensions #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2020
Merged

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Jun 21, 2020

fixes #1662

yaacovCR added 2 commits June 20, 2020 23:12

Verified

This commit was signed with the committer’s verified signature.
skarab42 Sébastien Mischler
ie extensions, so additional null checks required

initial change necessary for #1662

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@theguild-bot
Copy link
Collaborator

theguild-bot commented Jun 21, 2020

The latest changes of this PR are available as alpha in npm: 6.0.11-alpha-acf93e4.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.11-alpha-acf93e4.0

yaacovCR added 3 commits June 21, 2020 03:55

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
calling collectFields replaces selections with actual fieldNodes

Verified

This commit was signed with the committer’s verified signature.
skarab42 Sébastien Mischler

Verified

This commit was signed with the committer’s verified signature.
skarab42 Sébastien Mischler
@yaacovCR yaacovCR changed the title Failing test for #1662 fix combination of type merging and gateway type extensions Jun 21, 2020
@yaacovCR yaacovCR merged commit acf93e4 into master Jun 21, 2020
@yaacovCR yaacovCR deleted the fix-1662 branch June 21, 2020 09:01
@ardatan ardatan added the bugfix label Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema stitching doesn't work when mixing types merging and explicit resolver definition
3 participants