Modify ast nodes when transforming schemas #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each transform should also modify the underlying astnode and extensionASTNodes, if they exist. Initial change adds ast modification to: = RenameTypes = TransformCompositeFields TransformCompositeFields provides implementation for additional transforms: = TransformRootFields = FilterRootFields = RenameRootFields = TransformObjectFields = FilterObjectFields = RenameObjectFields = TransformInterfaceFields = FilterInterfaceFields = RenameInterfaceFields Still to do: = WrapFields (which provides implementation of WrapType) = HoistFields = PruneSchema = TransformInputIbjectFields (which provides implementation of FilterInputObjectFields and RenameInputObjectFields)
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
as well as implementing transforms FilterInputObjetFields and RenameInputObjectFields
Alas. This should be called MapFieldNodes, possible can be changes in the next major version.
and implementing transform WrapType
type astNodes can be updated to only include the ast for fields remaining after mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each transform should also modify the underlying astnode and extensionASTNodes, if they exist.
This PR also changes mapSchema to automatically update a type's astNode list of field definitions to match the actual field definitions includes within the type's new config map after mapping.
There is likely space for making sure to update additional astNodes within types to match the enclosed graphql type system objects, for example, enum types with the enclosed enum values. That may be included in a separate PR at this time.
Addresses #1747