Refactor GitLoader #1796
Merged
Refactor GitLoader #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrearden
commented
Jul 18, 2020
| @@ -34,11 +34,9 @@ export type GitLoaderOptions = SingleFileOptions & { | |||
| /** | |||
| * Additional options to pass to `graphql-tag-pluck` | |||
| */ | |||
| pluckConfig: GraphQLTagPluckOptions; | |||
| pluckConfig?: GraphQLTagPluckOptions; | |||
There was a problem hiding this comment.
Making this optional since graphql-tag-pluck doesn't actually require an options object to be passed in.
danielrearden
commented
Jul 18, 2020
| } | ||
| } | ||
|
|
||
| function ensureSource({ rawSDL, pointer, path }: { rawSDL: string; pointer: string; path: string }) { |
There was a problem hiding this comment.
Dropping ensureSource and createInvalidExtensionError because gqlPluckFromCodeString guarantees a string is returned and will already throw if an extension is invalid.
danielrearden
force-pushed
the
git-loader
branch
6 times, most recently
from
83f95dd
to
fb9b3d1
Compare
ardatan
approved these changes
Jul 18, 2020
danielrearden
force-pushed
the
git-loader
branch
from
fb9b3d1
to
c91596a
Compare
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing GitLoader's
loadSyncfunction is broken because it usessimple-gitandsimple-gitdoes not provide a way to execute git commands synchronously -- its API either uses Promises or callbacks. This PR refactors the loader to utilizeexec/execSyncinstead and adds tests.