Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull code from unmaintained prisma-yml package into prisma-loader package. #1841

Merged
merged 1 commit into from Jul 29, 2020

Conversation

andrewmcgivery
Copy link
Contributor

This PR looks to address #1813 wherein a high severity vulnerability is present in prisma-yml that isn't being patched. To fix this, the code from prisma-yml has been pulled into the prisma-loader package.

Some notes about this merge:

  • There is some less than ideal code in here coming in from the downstream repo. I made it pass the build and ESLINT on this repo but had to do a lot of not so ideal things such as usage of any, eslint ignores, and ts-ignores
  • I brought the tests from the downstream repo. I cannot vouch for their quality.

All tests passing:
image

Linted:
image

Vulnerability is mitigated:
image

@ardatan
Copy link
Owner

ardatan commented Jul 29, 2020

Thank you @andrewmcgivery ! That's awesome!

@ardatan ardatan merged commit b57b03b into ardatan:master Jul 29, 2020
@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm: 6.0.16-alpha-b57b03b9.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.16-alpha-b57b03b9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants