Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stitch): allow subschemas to not provide queries for merging #1842

Merged
merged 2 commits into from Jul 29, 2020

Conversation

yaacovCR
Copy link
Collaborator

Use case is a subschema in which the only defined fields are the key, so that merging is neither required nor really possible.

see #1839

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 29, 2020

The latest changes of this PR are available as alpha in npm: 6.0.16-alpha-f9936162.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.16-alpha-f9936162.0

@yaacovCR yaacovCR merged commit f993616 into master Jul 29, 2020
@yaacovCR yaacovCR deleted the refactor branch July 29, 2020 03:19
@gmac
Copy link
Contributor

gmac commented Jul 29, 2020

Neat, so if I'm reading this correctly: you no longer even need to provide subschema merge options for a schema with a unidirectional type? As long as a merged type is declared in at least one schema, it will be merged with other schemas of the same name everywhere? That's great! It also eliminates the margin of error to forget opting a type into merging somewhere.

@yaacovCR
Copy link
Collaborator Author

@gmac -- correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants