feat(mergeMocks): support Promise #1883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion it's a bug fix : mergeMocks function signature accept any type, so Promise type should be covered.
Context
In our application, we use the mocks with Promise result.
That gives us the possibility to test the "pending" and "error" state of a query or a mutation more easily. (and also the optimistic UI part can also be covered during pending state)
Actually it's really working fine and it's way easier to use on Frontend side compare to other mock utilities (for example the "mock" request system of apollo is awful)
We discover that if we define a custom mock + use Promise the custom mock override the expected result.
It's because of this test:
Promise is an object, but you can merge it as an object ...
--