enhance(typeMerging): add options #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ability to customize how type descriptions and conflicting fields are merged.
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
gmac
reviewed
Sep 5, 2020
| } | ||
|
|
||
| export interface TypeMergingOptions { | ||
| typeDescriptionsMerger?: (candidates: Array<MergeTypeCandidate>) => string; |
There was a problem hiding this comment.
This only does type descriptions, then? Field descriptions would go through the fieldConfigMerger?
There was a problem hiding this comment.
Yup. This could be improved further with an additional optional field description merger, but actually I'm not sure whether that would have to be instead of the field merger, or in addition, and if both are allowed, which one would operate first...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ability to customize how type descriptions and conflicting fields
are merged.
TODO: