Skip to content

enhance(stitch): simplify subschema sets #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Sep 4, 2020

further simplified subschema config sets by simply using an array of SubschemaConfig objects

Named endpoints are no longer necessary, as common endpoints can simply be used by using identical (===) endpoint objects which will allow query batching across subschemas.

Technically, there is now no difference from including an array of SubschemaConfig objects within the subschemas property or simply spreading the arrray into the subschemas property, whatever is simpler for end-users.

@yaacovCR yaacovCR force-pushed the subschema-set-config branch from 95f31ac to 3c1c7e0 Compare September 4, 2020 07:59

Verified

This commit was signed with the committer’s verified signature.
skarab42 Sébastien Mischler
further simplified subschema config sets by simply using an array of SubschemaConfig objects

Named endpoints are no longer necessary, as common endpoints can simply be used by using identical (===) endpoint objects which will allow query batching across subschemas.

Technically, there is now no difference from including an array of SubschemaConfig objects within the `subschemas` property or simply spreading the arrray into the subschemas property, whatever is simpler for end-users.
@theguild-bot
Copy link
Collaborator

theguild-bot commented Sep 4, 2020

The latest changes of this PR are available as alpha in npm: 6.2.1-alpha-fe85dcb8.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.2.1-alpha-fe85dcb8.0

@yaacovCR yaacovCR merged commit fe85dcb into master Sep 4, 2020
@yaacovCR yaacovCR deleted the subschema-set-config branch September 4, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants