Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(stitch) Test merge conflicts #2006

Merged
merged 3 commits into from Sep 11, 2020

Conversation

gmac
Copy link
Contributor

@gmac gmac commented Sep 7, 2020

Adds tests for merge conflicts. These work well enough, although they're pretty opaque for an extremely common use case like picking the right docstring. It'd be nice if there was some way to provide a friendly facade for this type of setup along the lines of:

combineDescriptions({ delimiter: '\n', ignorePrefix: 'ignore!' });

Obviously, we wouldn't want that to interfere with the ability to still take advantage of these merge handlers for other truly specialized use cases. Any ideas for how something like this could be cleanly packaged?

Either way, these tests hit merge handlers so provide worthwhile coverage!

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@yaacovCR
Copy link
Collaborator

Thanks @gmac!

@yaacovCR yaacovCR merged commit 65b41f0 into ardatan:master Sep 11, 2020
@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm: 6.2.2-alpha-65b41f0a.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.2.2-alpha-65b41f0a.0

@gmac gmac deleted the gm-merge-conflicts-test branch January 8, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants