Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove casual dependency #39

Merged
merged 1 commit into from Apr 21, 2016
Merged

remove casual dependency #39

merged 1 commit into from Apr 21, 2016

Conversation

helfer
Copy link
Contributor

@helfer helfer commented Apr 21, 2016

Pretty straight forward. Random generator can't be seeded, but you can override the defaults to get deterministic behavior. Maybe we'll put in something seedable later.

@stubailo
Copy link
Contributor

Maybe instead of random, we want static results? I feel that would make the default mocks a lot more useful for testing.

@helfer
Copy link
Contributor Author

helfer commented Apr 21, 2016

Idk, I would assume that for testing people will just set the mocks to what they want. It's only 5 scalar types after all.

@helfer
Copy link
Contributor Author

helfer commented Apr 21, 2016

I should add that making it random has the benefit of looking at least a tiny bit more realistic.

@stubailo
Copy link
Contributor

@helfer I really think we should have a separate "mocking" page in the docs rather than one giant "API" page. Then it will be much easier to find code snippets and stuff.

@helfer
Copy link
Contributor Author

helfer commented Apr 21, 2016

You mean make mocking a third top-level thing like the tutorial and the tools section? That could certainly be done. Do you want to file an issue on the docs?

@helfer helfer merged commit f11df8b into master Apr 21, 2016
@helfer helfer deleted the remove-casual branch September 20, 2016 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants