Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger to mergeSchemas #434

Closed
pyrossh opened this issue Oct 16, 2017 · 2 comments
Closed

Add logger to mergeSchemas #434

pyrossh opened this issue Oct 16, 2017 · 2 comments

Comments

@pyrossh
Copy link

pyrossh commented Oct 16, 2017

I need to debug errors during development and makeExecutableSchema has this nice logger parameter to log the stack traces of the errors which get swallowed by graphql.

But since the new 2.5.0 version and stitching schema's I need to pass the same logger parameter to all my schemas. Since mergeSchemas is a central place can we have the the logger parameter there also and use that to log all errors instead of repeating it always.

@freiksenet
Copy link
Contributor

Sounds like a great idea, that's something we definitely want. And we definitely would welcome PRs that would implement it.

@stubailo
Copy link
Contributor

I think we want to improve error handling overall, and will probably be deprecating the logger parameter. But we want to make sure we have a good replacement before we do. #887

In general, I'm also going to be dramatically improving error handling in schema stitching overall. Follow along here: #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants