Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mock] relayStylePaginationMock sometimes returns an incorrect value for hasNextPage #5890

Open
3 of 4 tasks
croaker opened this issue Feb 9, 2024 · 0 comments
Open
3 of 4 tasks

Comments

@croaker
Copy link

croaker commented Feb 9, 2024

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub here
  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

hasNextPage is erroneously false on the second-to-last page if the last page only contains a single node.

To Reproduce Steps to reproduce the behavior:

Insert expect(page2Items.pageInfo.hasNextPage).toBeTruthy(); above line 103 in packages/mock/tests/pagination.spec.ts. After this change, the test fails because page2Items.pageInfo.hasNextPage is erroneously false at this point.

Pull Request: #5891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant