Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globalGqlIdentifierName is inconsistently forced lowercase so doesn't work with mixed case identifiers #5944

Open
3 of 4 tasks
fantastiskm opened this issue Feb 29, 2024 · 1 comment

Comments

@fantastiskm
Copy link

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

    Make sure to fork this template and run yarn generate in the terminal.

    Please make sure the GraphQL Tools package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

globalGqlIdentifierName are set to be lower case in tag-pluck but when the visitor uses them it does a case sensitive compare

To Reproduce Steps to reproduce the behavior:

pluckConfig: {
globalGqlIdentifierName: ['helloGql']
}
const query = helloGql(`
[snip]
`);

Expected behavior

Case sensitive identifiers can match. Either globalGqlIdentifierName shouldn't be converted to lower case or identifiers in the code should be. Changing the comparison to be case insensitive should not break backward compatibility whereas changing it to be case sensitive may.

Environment:

  • OS: MacOs
  • @graphql-tools/...: 8.3
  • NodeJS: 18

Additional context

@fantastiskm
Copy link
Author

#5945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant