Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error: Remove trailing comma after rest arg #792

Closed
cspotcode opened this issue May 18, 2018 · 2 comments
Closed

Syntax error: Remove trailing comma after rest arg #792

cspotcode opened this issue May 18, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@cspotcode
Copy link

There's a trailing comma after a rest parameter. This won't be allowed in TypeScript 2.9, so as to match the ECMAScript spec.

https://github.com/apollographql/graphql-tools/blob/master/src/stitching/delegateToSchema.ts#L35

Blog post where they announce the change: https://blogs.msdn.microsoft.com/typescript/2018/05/16/announcing-typescript-2-9-rc/
Github issue for the change: microsoft/TypeScript#22262

It's very minor, I know, but I discovered it because recast attempts to parse the graphql codebase in its unit tests, and this file was failing to parse. And if you ever want to upgrade to TS2.9 you'll have to remove it anyway.

@JakeDawkins
Copy link
Contributor

We'd be willing to accept this PR if (or anyone else) could open it!

@hwillson hwillson added the help wanted Extra attention is needed label Sep 7, 2018
@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

Closing stale issue

@yaacovCR yaacovCR closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants