AddArgumentsAsVariables assumes operation.variableDefinitions an array

[jakealbert]

I'm hitting a case where the query operation.variableDefinitions is null, but the AddArgumentsAsVariables transformer calls .map and .concat.

It's not immediately clear whether AddArgumentsAsVariables should be checking for null or if variableDefinitions should always be an array. From the graphql-tag README, it certainly seems valid for variableDefinitions to be null.

[ostrgard]

I'm having this same issue and have a hard time finding a workaround. Did you find one, @jakealbert?

[jakealbert]

You can hack the AST definitions from the context of validationRules:

const validationRules = [
  context => {
    context._ast.definitions.forEach(definition => {
      definition.variableDefinitions = definition.variableDefinitions || []
    })
    return true
  }
]

then pass validationRules along with your schema:

graphqlExpress(req => ({ schema, validationRules }))

[ostrgard]

Thanks a lot, @jakealbert!

[stubailo]

Does anyone want to sent a PR with a fix? Should be like, one line to guard against null in that code.

[yaacovCR]

Review of current code in next branch looks ok, seems to be fixed by #1306