Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Merge Schemas behavior and remove legacy signature in addResolversToSchema #4463

Merged
merged 7 commits into from Aug 9, 2022
Merged

Fix Merge Schemas behavior and remove legacy signature in addResolversToSchema #4463

merged 7 commits into from Aug 9, 2022

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented May 17, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022 •
edited

🦋 Changeset detected

Latest commit: 0665c0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@graphql-tools/schema Major
@graphql-tools/delegate Major
@graphql-tools/wrap Major
@graphql-tools/batch-delegate Patch
graphql-tools Patch
@graphql-tools/load Patch
@graphql-tools/mock Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/links Patch
@graphql-tools/url-loader Patch
@graphql-tools/node-require Patch
federation-benchmark Patch
@graphql-tools/prisma-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 17, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ❌ Failed (Inspect) Aug 9, 2022 at 4:32PM (UTC)

@theguild-bot
Copy link
Collaborator

theguild-bot commented May 17, 2022 •
edited

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-tools/batch-delegate@8.2.20-alpha-7052f15d.0
@graphql-tools/delegate@8.7.11-alpha-7052f15d.0
graphql-tools@8.2.12-alpha-7052f15d.0
@graphql-tools/links@8.2.18-alpha-7052f15d.0
@graphql-tools/load@7.5.14-alpha-7052f15d.0
@graphql-tools/prisma-loader@7.1.23-alpha-7052f15d.0
@graphql-tools/url-loader@7.9.24-alpha-7052f15d.0
@graphql-tools/mock@8.6.12-alpha-7052f15d.0
@graphql-tools/node-require@6.3.14-alpha-7052f15d.0
@graphql-tools/schema@9.0.0-alpha-7052f15d.0
@graphql-tools/stitch@8.6.13-alpha-7052f15d.0
@graphql-tools/stitching-directives@2.2.18-alpha-7052f15d.0
@graphql-tools/wrap@8.4.20-alpha-7052f15d.0

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2022 •
edited

❌ Benchmark Failed

Performance regression detected: it seems like your Pull Request adds some extra latency to Schema Stitching

If the performance regression is expected, please increase the failing threshold.

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 212      ✗ 0  
     data_received..................: 25 MB   2.5 MB/s
     data_sent......................: 91 kB   9.0 kB/s
     http_req_blocked...............: avg=20.44µs  min=3.1µs   med=4.2µs   max=1.69ms   p(90)=6.15µs   p(95)=6.6µs   
     http_req_connecting............: avg=15.19µs  min=0s      med=0s      max=1.61ms   p(90)=0s       p(95)=0s      
   ✗ http_req_duration..............: avg=88.97ms  min=76.92ms med=83.83ms max=190.39ms p(90)=92.7ms   p(95)=135.87ms
       { expected_response:true }...: avg=88.97ms  min=76.92ms med=83.83ms max=190.39ms p(90)=92.7ms   p(95)=135.87ms
     http_req_failed................: 0.00%   ✓ 0        ✗ 106
     http_req_receiving.............: avg=195.93µs min=165.8µs med=185.3µs max=482.2µs  p(90)=210.4µs  p(95)=241.2µs 
     http_req_sending...............: avg=167.75µs min=22.3µs  med=31.35µs max=4.07ms   p(90)=48.25µs  p(95)=622.93µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=88.61ms  min=76.69ms med=83.5ms  max=189.94ms p(90)=92.31ms  p(95)=135.63ms
     http_reqs......................: 106     10.53133/s
     iteration_duration.............: avg=94.9ms   min=81.96ms med=89.45ms max=197.07ms p(90)=101.74ms p(95)=140.87ms
     iterations.....................: 106     10.53133/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

@borisno2
Copy link

Hi @ardatan any update on this?

@dcousens
Copy link

dcousens commented May 30, 2022 •
edited

Hi @ardatan, is there anything we can do to help this through?

We're balancing whether we should polyfill the fixes from #4455 for ourselves locally or wait on this pull request. Happy either way, but wondering if we can help upstream first.

@borisno2 borisno2 mentioned this pull request May 30, 2022
Closed
@ardatan
Copy link
Owner Author

ardatan commented Jun 2, 2022

Feel free to use posted canary versions until we release.

@ardatan ardatan force-pushed the master branch 2 times, most recently from 4946aeb to 4be9073 Compare July 20, 2022 20:01
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022 •
edited

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 8.3.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/batch-execute 8.5.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 9.0.0-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-tag-pluck 7.3.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
graphql-tools 8.3.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/import 6.7.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/jest-transform 1.2.1-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/links 8.3.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/load 7.7.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/load-files 6.6.1-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/apollo-engine-loader 7.3.7-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/code-file-loader 7.3.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/git-loader 7.2.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/github-loader 7.3.7-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-file-loader 7.5.1-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/json-file-loader 7.4.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/module-loader 7.2.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 7.2.9-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/url-loader 7.13.4-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/merge 8.3.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/mock 8.7.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/node-require 6.4.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/optimize 1.3.1-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/relay-operation-optimizer 6.5.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/resolvers-composition 6.5.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/schema 9.0.0-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 8.7.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 2.3.2-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/utils 8.9.1-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/webpack-loader 6.7.1-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/webpack-loader-runtime 6.4.1-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 9.0.0-alpha-20220809163138-2baff42f npm ↗︎ unpkg ↗︎

@ardatan ardatan merged commit 8cc8721 into master Aug 9, 2022
@ardatan ardatan deleted the merge-schemas-fix branch August 9, 2022 17:23
@github-actions github-actions bot mentioned this pull request Aug 9, 2022
Merged
@mattkrick mattkrick mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ardatan @theguild-bot @borisno2 @dcousens