Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Landscape Variation #51

Open
DjamelALI opened this issue Jun 11, 2020 · 5 comments
Open

Create Landscape Variation #51

DjamelALI opened this issue Jun 11, 2020 · 5 comments
Assignees

Comments

@DjamelALI
Copy link
Contributor

Description

Allow only portrait mode in phones, landscape and portrait mode
in tablets.

Steps to reproduce

Create all the layouts required in landscape mode, and test in the code to see if you have to accept the change of screen orientation or not (depending on the screen dimensions).

Expected behavior

  • Allow only portrait mode in phones, landscape and portrait mode
    in tablets. (force portrait mode for phones, portrait and landscape mode for tablets (for screens greater than 600 dp)).

  • Ensure that when the tablet changes orientation, the application does not lose data already entered in portrait mode, and vice versa.

  • Note : if you don't have tablets, you can test with the virtual tablets provided by android studio (in avd - android virtual device).

Actual behavior

Only the portrait mode works as expected.

Who's working on this ?

I can do that if you want.
(If you give me to work on issue #17, I'll do it later).

@ardovic
Copy link
Owner

ardovic commented Jun 13, 2020

Great description of issue and idea. It would be very beneficial for the app. I've assigned you onto it, feel free to start at any time!

@DjamelALI
Copy link
Contributor Author

Great description of issue and idea. It would be very beneficial for the app. I've assigned you onto it, feel free to start at any time!

All right, thank you !
I'll start working on it tomorrow.

@leila94
Copy link
Contributor

leila94 commented Feb 3, 2021

Is this still an open issue?

@DjamelALI
Copy link
Contributor Author

Is this still an open issue?

Hello !

Sorry, finally I didn't have enough free time to do it.
Hopefully @ardovic will be able to assign this task to you very soon.
Good luck :)
@leila94

@DjamelALI DjamelALI removed their assignment Feb 3, 2021
@leila94
Copy link
Contributor

leila94 commented Feb 3, 2021

Is this still an open issue?

Hello !

Sorry, finally I didn't have enough free time to do it.
Hopefully @ardovic will be able to assign this task to you very soon.
Good luck :)
@leila94

Thank you. I will start it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants