Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock serial monitor close and open / add checks #218

Open
smellai opened this issue Apr 10, 2018 · 2 comments
Open

Lock serial monitor close and open / add checks #218

smellai opened this issue Apr 10, 2018 · 2 comments
Assignees
Labels
type: enhancement Proposed improvement

Comments

@smellai
Copy link
Contributor

smellai commented Apr 10, 2018

Possible bug when sending open when close in progress and not yet completed.
Possible similar cases.

I tried to add checks in the frontend but it doesn't seem to fix the issues. In some cases compilation/upload stays pending or ends with 'touch error'

@smellai smellai added the type: enhancement Proposed improvement label Apr 10, 2018
@smellai
Copy link
Contributor Author

smellai commented Apr 10, 2018

The agent could better control serial monitor connections and disconnections in general, it could improve this too for example: https://github.com/bcmi-labs/webide/issues/2933

@AlbyIanna AlbyIanna reopened this Aug 8, 2018
@umbynos
Copy link
Contributor

umbynos commented Feb 5, 2021

To solve this issue we could better handle the open/close.
Something could be offloaded from the frontend: When the WebSocket is closed the agent could close all the ports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

4 participants