Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/update endpoint does not work properly on macos #608

Open
umbynos opened this issue Jan 28, 2021 · 0 comments
Open

/update endpoint does not work properly on macos #608

umbynos opened this issue Jan 28, 2021 · 0 comments
Labels
type: imperfection Perceived defect in any part of project

Comments

@umbynos
Copy link
Contributor

umbynos commented Jan 28, 2021

Bug Report

Describe the bug

When a POST request is sent to the agent on macos to the /update endpoint the communication is truncated because systray is run in the main thread and causes the gin goroutine to not exit gracefully. This behaviour is present only in the mac os version 🤷🏼‍♂️

To Reproduce

curl -X POST http://127.0.0.1:8991/update on macos version

Expected behavior

get {"success":"Please wait a moment while the agent reboots itself"} instead of connection closed

Environment (please complete the following information):

  • OS [e.g. Windows]: MacOS
  • OS version: 11 (Big Sur)
  • Browser [e.g. chrome, safari]: not a browser related problem
  • Browser Version:
  • Agent Version [e.g. 1.0.0]: 1.2.0

Additional context

@fstasi fstasi removed the type: bug label Sep 16, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

3 participants