Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script annotation inputs doesn't play well with with_param #861

Open
3 of 4 tasks
elliotgunton opened this issue Nov 13, 2023 · 0 comments
Open
3 of 4 tasks

Script annotation inputs doesn't play well with with_param #861

elliotgunton opened this issue Nov 13, 2023 · 0 comments
Labels
type:bug A general bug

Comments

@elliotgunton
Copy link
Collaborator

elliotgunton commented Nov 13, 2023

Pre-bug-report checklist

1. This bug can be reproduced using YAML

2. This bug occurs when...

  • running Hera code without submitting to Argo (e.g. when exporting to YAML)
  • running Hera code and submitting to Argo

Bug report

Describe the bug
When using script annotations, an alternative name can be specified. When using with_param, it checks through the python names only, here. When using the alternative name in an arguments={"param-name": "a value"} alongside a with_param, the with_param will populate the other arguments as param_name.

This will then fail on submission to Argo with

inputs.parameters.param-name was not supplied

I'll add a reproducible example here soon!

Expected behavior
Annotated names are also checked/linked with the python names (then probably always use the alternative name if specified)

Environment

  • Hera Version: 5.9.0
  • Python Version: 3.11.6
  • Version of Argo: 3.X.X

Additional context
Add any other context about the problem here.

@elliotgunton elliotgunton added the type:bug A general bug label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant