Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a hera mypy plugin #911

Open
samj1912 opened this issue Dec 27, 2023 · 1 comment
Open

Create a hera mypy plugin #911

samj1912 opened this issue Dec 27, 2023 · 1 comment
Labels
type:enhancement A general enhancement

Comments

@samj1912
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Hera currently doesn't have great mypy integration. There are often type errors and input args/paramters are not validated at all.

Describe the solution you'd like

It would be great is hera shipped with a mypy plugin - https://mypy.readthedocs.io/en/stable/extending_mypy.html#extending-mypy-using-plugins

This would be similar to https://docs.pydantic.dev/2.0/api/mypy/

Describe alternatives you've considered

N/A

Additional context
@samj1912 samj1912 added the type:enhancement A general enhancement label Dec 27, 2023
@mshatkhin23 mshatkhin23 mentioned this issue Jan 5, 2024
Merged
4 tasks
samj1912 pushed a commit that referenced this issue Jan 5, 2024
@mshatkhin23
Fix mypy default args issues in Workflow (#918)
ecd0c70 
**Pull Request Checklist**
- [ ] Towards fixing #911
- [ ] Tests added
- [ ] Documentation/examples added
- [ ] [Good commit messages](https://cbea.ms/git-commit/) and/or PR
title

**Description of PR**
Fixes mypy linting issues with default args for mixin fields of
arguments, metrics, volumes in workflow.py

Signed-off-by: Max Shatkhin <mshatkhin23@users.noreply.github.com>
@DanCardin
Copy link
Contributor

I wonder if #950 fixes this issue, or did you have something else in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanCardin @samj1912