docs(declarative/repo-ssh): url needs git suffix

[IzioDev]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (e48c9e1) 49.76% compared to head (ce040ef) 49.77%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #13894   +/-   ##
=======================================
  Coverage   49.76%   49.77%           
=======================================
  Files         261      261           
  Lines       44667    44667           
=======================================
+ Hits        22230    22233    +3     
+ Misses      20251    20249    -2     
+ Partials     2186     2185    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[morey-tech]

I'm not sure that the URL needs the .git extension. Based on this test, the repo-server should normalize the URL to include it.

[IzioDev]

interesting @morey-tech, do you know for which argocd version this test was run against?

without the .git it didn't work on my end, but I might have a specific configuration or version that didn't do it?

EDIT: I will try to give my current configuration this evening, on the relevant part, as well as the version I'm using if it helps investigate.

Shall we close this PR and move to an issue if I can reproduce it?

[morey-tech]

interesting @morey-tech, do you know for which argocd version this test was run against?

I referenced the latest, so v2.7 would definitely have it, but it looks like the normalization of the URLs has been a part of Argo CD since v0.

without the .git it didn't work on my end, but I might have a specific configuration or version that didn't do it?

I see now that some Git providers require that the .git extension be used. What's your provider?

argo-cd/docs/operator-manual/declarative-setup.md

Line 171 in 8840929

Some Git hosters - notably GitLab and possibly on-premise GitLab instances as well - require you to

Shall we close this PR and move to an issue if I can reproduce it?

This might not be an issue, more of a nuance of how some Git providers work. But creating an issue would make this more discoverable for anyone who runs into it in the future.

[morey-tech]

This may be related to #7714. It seems that the normalized repo URL is only used in some cases. The git client is still initialized with the raw repo URL.

argo-cd/util/git/client.go

Line 145 in 8840929

normalizedGitURL := NormalizeGitURL(rawRepoURL)

argo-cd/util/git/client.go

Line 153 in 8840929

return NewClientExt(rawRepoURL, root, creds, insecure, enableLfs, proxy, opts...)

[IzioDev]

What's your provider?

It's Github, private repository, repo isn't at an organization level but as a user repository

[IzioDev]

Here is my configuration:

apiVersion: v1
kind: Secret
metadata:
    name: private-repo
    namespace: argocd
    labels:
        argocd.argoproj.io/secret-type: repository
stringData:
    type: git
    url: git@github.com:IzioDev/test-argocd.git
    sshPrivateKey: |-

[morey-tech]

It makes sense to add the suffix if even GitHub requires it.

[IzioDev]

@morey-tech Do you know if other repository reference are impacted too by this change? Shall we change it for all mentioning of reference or only the SSH secret part is enough?

[pasha-codefresh]

LGTM