chore: improve reposerver readability #14112
Merged
+57
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14112 +/- ##
==========================================
- Coverage 49.61% 49.61% -0.01%
==========================================
Files 256 256
Lines 43934 43926 -8
==========================================
- Hits 21800 21792 -8
Misses 19975 19975
Partials 2159 2159
☔ View full report in Codecov by Sentry. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Signed-off-by: yyzxw <1020938856@qq.com>
crenshaw-dev
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
This is a massive improvement, thanks @yyzxw!
I'm going to hold off merging until we cut 2.8-rc1. Want to avoid PRs having to rebase if they've touched this code.
ishitasequeira
approved these changes
Jun 21, 2023
|
@crenshaw-dev i can see that 2.8-rc1 already out , do you want to merge it? |
|
Thanks for the reminder, @pasha-codefresh! |
yyzxw
added a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
Signed-off-by: yyzxw <1020938856@qq.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
Signed-off-by: yyzxw <1020938856@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.