feat: make git requests configurable #15646
Merged
+106
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishitasequeira
requested changes
Sep 24, 2023
alexmt
force-pushed
the
feat/configurable-git-client-timeout
branch
from
1f08e30 to
e5a6aee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15646 +/- ##
==========================================
+ Coverage 49.53% 49.54% +0.01%
==========================================
Files 269 269
Lines 46622 46641 +19
==========================================
+ Hits 23095 23110 +15
- Misses 21255 21258 +3
- Partials 2272 2273 +1
☔ View full report in Codecov by Sentry. |
|
Should this be configured via a CLI arg/env var default on the repo-server command? Would improve discoverability. |
alexmt
force-pushed
the
feat/configurable-git-client-timeout
branch
from
e5a6aee to
61384b5
Compare
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
feat/configurable-git-client-timeout
branch
from
61384b5 to
f40f4f8
Compare
gdsoumya
approved these changes
Oct 23, 2023
|
Thank you for review @crenshaw-dev and @ishitasequeira ! I've kept working on debugging the issue caused by the slow git provider and realized another setting is required: PTAL |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
feat/configurable-git-client-timeout
branch
from
97ed3f6 to
47c15cd
Compare
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
ymktmk
pushed a commit
to ymktmk/argo-cd
that referenced
this pull request
Oct 29, 2023
* feat: make git requests configurable Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * docs: mention new settings in 'argocd-cmd-params-cm' configmap Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * add comment about ignored error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
* feat: make git requests configurable Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * docs: mention new settings in 'argocd-cmd-params-cm' configmap Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * add comment about ignored error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> git rebase HEAD~73 --signoff
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
* feat: make git requests configurable Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * docs: mention new settings in 'argocd-cmd-params-cm' configmap Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * add comment about ignored error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* feat: make git requests configurable Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * docs: mention new settings in 'argocd-cmd-params-cm' configmap Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * add comment about ignored error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Jan 19, 2024
* feat: make git requests configurable Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * docs: mention new settings in 'argocd-cmd-params-cm' configmap Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * add comment about ignored error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* feat: make git requests configurable Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * docs: mention new settings in 'argocd-cmd-params-cm' configmap Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * add comment about ignored error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces an
ARGOCD_GIT_REQUEST_TIMEOUTenv variable that allows configuring git request timeouts (currently 15s by default)