Skip to content

feat(cli): add the cluster-list-example (#15690) #15866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 18, 2023
Merged

feat(cli): add the cluster-list-example (#15690) #15866

merged 4 commits into from
Oct 18, 2023
+39 −0

Conversation

gaurangkudale
Copy link
Contributor

add the cluster-list-example for improvement for #15690

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Sorry, something went wrong.

@gaurangkudale gaurangkudale requested review from a team as code owners October 7, 2023 21:25
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (99a4bf0) 49.67% compared to head (1287039) 49.66%.
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15866      +/-   ##
==========================================
- Coverage   49.67%   49.66%   -0.01%     
==========================================
  Files         267      267              
  Lines       46383    46399      +16     
==========================================
+ Hits        23039    23043       +4     
- Misses      21084    21096      +12     
  Partials     2260     2260
Files Coverage Δ
cmd/argocd/commands/cluster.go 7.41% <ø> (ø)
util/helm/cmd.go 35.21% <100.00%> (+1.14%) ⬆️
...cationset/controllers/applicationset_controller.go 60.39% <0.00%> (-0.11%) ⬇️
cmd/argocd/commands/project_role.go 0.00% <0.00%> (ø)
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira
ishitasequeira requested changes Oct 10, 2023
View reviewed changes
docs/user-guide/commands/argocd_cluster_list.md
argocd cluster list -o json --server <ARGOCD_SERVER_ADDRESS>

# List Clusters in YAML Format
argocd cluster list -o yaml --server <ARGOCD_SERVER_ADDRESS>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an example for -o server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes
I have added the example

@gaurangkudale
Copy link
Contributor Author

Hi @ishitasequeira
I have done the changes

@gaurangkudale
Copy link
Contributor Author

Hi @crenshaw-dev
In your free time Can you please review and merge it

@gaurangkudale
update the cluster.go for list Signed-off-by: Author Name gaurang.kud…
906def3 
…ale02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale
update the reverting changes Signed-off-by: Author Name gaurang.kudal…
9b7e628 
…e02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale
update the reverting changes Signed-off-by: Author Name gaurang.kudal…
2e965e9 
…e02@gmail.com

Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
@gaurangkudale
update the string Signed-off-by: Author Name gaurang.kudale02@gmail.com
1287039 
Signed-off-by: Gaurang Kudale <gaurang.kudale02@gmail.com>
ishitasequeira
ishitasequeira approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaurangkudale. LGTM!

@ishitasequeira ishitasequeira enabled auto-merge (squash) October 18, 2023 01:06
@ishitasequeira ishitasequeira merged commit 1a43ff6 into argoproj:master Oct 18, 2023
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@gaurangkudale @ymktmk
feat(cli): add the cluster-list-example (argoproj#15690) (argoproj#15866
6c2b03f 
)
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@gaurangkudale @jmilic1
feat(cli): add the cluster-list-example (argoproj#15690) (argoproj#15866
3fdd722 
)

Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@gaurangkudale @vladfr
feat(cli): add the cluster-list-example (argoproj#15690) (argoproj#15866

Verified

This commit was signed with the committer’s verified signature.
vladfr Vlad Fratila
GPG key ID: 9A9FE9C1DC8ECB90
Verified
Learn about vigilant mode
19c22c1 
)
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@gaurangkudale @tesla59
feat(cli): add the cluster-list-example (argoproj#15690) (argoproj#15866
6757ec8 
)
lukaszgyg pushed a commit to lukaszgyg/argo-cd that referenced this pull request Jan 12, 2024
@gaurangkudale @lukaszgyg
feat(cli): add the cluster-list-example (argoproj#15690) (argoproj#15866
cf27a08 
)
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@gaurangkudale @Hariharasuthan99
feat(cli): add the cluster-list-example (argoproj#15690) (argoproj#15866
6bea499 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaurangkudale @ishitasequeira @crenshaw-dev