Skip to content

feat: Add examples to --help output for remaining "create PROJECT ROLE-NAME" #15983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2023
Merged

feat: Add examples to --help output for remaining "create PROJECT ROLE-NAME" #15983

merged 2 commits into from
Oct 27, 2023
+13 −0

Conversation

Ratangulati
Copy link
Contributor

Created abother PR to address #15690 #L140

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Sorry, something went wrong.

@Ratangulati
feat: Add examples to --help output for remaining create PROJECT ROLE…
bcddcc0 
…-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>
@Ratangulati
feat: Add examples to --help output for remaining create PROJECT ROLE…
bf71aa2 
…-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>
@Ratangulati Ratangulati requested review from a team as code owners October 16, 2023 15:41
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dbc48f3) 49.67% compared to head (bf71aa2) 49.66%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15983      +/-   ##
==========================================
- Coverage   49.67%   49.66%   -0.01%     
==========================================
  Files         267      267              
  Lines       46383    46388       +5     
==========================================
  Hits        23039    23039              
- Misses      21084    21089       +5     
  Partials     2260     2260
Files Coverage Δ
cmd/argocd/commands/project_role.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crenshaw-dev
crenshaw-dev approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Ratangulati!

@crenshaw-dev crenshaw-dev merged commit 0c91395 into argoproj:master Oct 27, 2023
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@Ratangulati @ymktmk
feat: Add examples to --help output for remaining "create PROJECT ROL…
437737f 
…E-NAME" (argoproj#15983)

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

---------

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@Ratangulati @jmilic1
feat: Add examples to --help output for remaining "create PROJECT ROL…
ee7839f 
…E-NAME" (argoproj#15983)

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

---------

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@Ratangulati @vladfr
feat: Add examples to --help output for remaining "create PROJECT ROL…

Verified

This commit was signed with the committer’s verified signature.
vladfr Vlad Fratila
GPG key ID: 9A9FE9C1DC8ECB90
Verified
Learn about vigilant mode
a805606 
…E-NAME" (argoproj#15983)

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

---------

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@Ratangulati @tesla59
feat: Add examples to --help output for remaining "create PROJECT ROL…
2da83fa 
…E-NAME" (argoproj#15983)

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

---------

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@Ratangulati @lyda
feat: Add examples to --help output for remaining "create PROJECT ROL…

Verified

This commit was signed with the committer’s verified signature.
lyda Kevin Lyda
GPG key ID: 67427E5B715D2B4A
Verified
Learn about vigilant mode
819fea7 
…E-NAME" (argoproj#15983)

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

---------

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@Ratangulati @Hariharasuthan99
feat: Add examples to --help output for remaining "create PROJECT ROL…
4076884 
…E-NAME" (argoproj#15983)

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

* feat: Add examples to --help output for remaining create PROJECT ROLE-NAME

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>

---------

Signed-off-by: Ratan Gulati <ratangulati.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ratangulati @crenshaw-dev