Skip to content

feat: add write back to application informer #15987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 24, 2023
Merged

feat: add write back to application informer #15987

merged 13 commits into from
Oct 24, 2023
+43 −23

Conversation

gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Oct 16, 2023 •
edited
Loading

This PR adds informer cache writebacks (like rollouts) to update the application cache faster.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Sorry, something went wrong.

gdsoumya and others added 2 commits October 16, 2023 23:43
@gdsoumya gdsoumya force-pushed the feat/informerWriteBack branch from c4b0def to 260da6b Compare October 16, 2023 18:30
gdsoumya and others added 4 commits October 17, 2023 09:40
@gdsoumya
fix: unit test
2649c35 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya
Merge branch 'master' into feat/informerWriteBack

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9416ba6
@gdsoumya
fix: unit test
c76a301 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya
Merge branch 'feat/informerWriteBack' of github.com:gdsoumya/argo-cd …
d3edec7 
…into feat/informerWriteBack
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f4e0d35) 49.53% compared to head (034a6da) 49.55%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15987      +/-   ##
==========================================
+ Coverage   49.53%   49.55%   +0.01%     
==========================================
  Files         269      269              
  Lines       46627    46641      +14     
==========================================
+ Hits        23097    23112      +15     
+ Misses      21259    21257       -2     
- Partials     2271     2272       +1
Files Coverage Δ
controller/appcontroller.go 54.18% <80.00%> (+0.33%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdsoumya gdsoumya marked this pull request as ready for review October 17, 2023 05:27
@gdsoumya gdsoumya requested a review from a team as a code owner October 17, 2023 05:27
gdsoumya and others added 2 commits October 17, 2023 11:01
@gdsoumya
feat: updated doc comment
ab6d282 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya
Merge branch 'master' into feat/informerWriteBack

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
de10e50
@gdsoumya
feat: dry out code for patch + writebacks
bd97538 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya force-pushed the feat/informerWriteBack branch from 4958335 to bd97538 Compare October 20, 2023 05:06
@gdsoumya
Merge branch 'master' into feat/informerWriteBack

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6a14a57
@gdsoumya gdsoumya requested a review from jessesuen October 20, 2023 05:08
@gdsoumya
refactor: remove logs
38f96a2 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya requested a review from jessesuen October 20, 2023 19:38
@gdsoumya
Merge branch 'master' into feat/informerWriteBack

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
345787b
@gdsoumya gdsoumya requested a review from alexmt October 23, 2023 16:47
alexmt
alexmt approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gdsoumya
Merge branch 'master' into feat/informerWriteBack

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
034a6da 
Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com>
@jessesuen
Copy link
Member

Thank you! I think this will resolve a lot of timing related issues that have happened from the status reconciler vs. the operation reconciler.

@jessesuen jessesuen merged commit a43b799 into argoproj:master Oct 24, 2023
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@gdsoumya @ymktmk
feat: add write back to application informer (argoproj#15987)
b59a493 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@gdsoumya @jmilic1
feat: add write back to application informer (argoproj#15987)
9c98c62 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@gdsoumya @vladfr
feat: add write back to application informer (argoproj#15987)

Verified

This commit was signed with the committer’s verified signature.
vladfr Vlad Fratila
GPG key ID: 9A9FE9C1DC8ECB90
Verified
Learn about vigilant mode
2d1dc36 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@gdsoumya @tesla59
feat: add write back to application informer (argoproj#15987)
9383007 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@gdsoumya @Hariharasuthan99
feat: add write back to application informer (argoproj#15987)
b1c8687 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt

@jessesuen jessesuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdsoumya @jessesuen @alexmt