Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Edit support in Sources tab for multi-source apps #17588

Open
keithchong opened this issue Mar 21, 2024 · 0 comments · May be fixed by #17890
Open

Provide Edit support in Sources tab for multi-source apps #17588

keithchong opened this issue Mar 21, 2024 · 0 comments · May be fixed by #17890
Assignees
@keithchong
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@keithchong
Copy link
Contributor

keithchong commented Mar 21, 2024 •
edited

Summary

This is to cover the Edit support from the proposal: #17108.

This adds or builds upon the changes from PR 17275 . (It was meant to be done in stages to make reviewing easier, so this PR includes those changes).

This change adds the "Edit" button to the source and parameter inputs collapsible panels under the Sources tab.

Proposal

See proposal here, multiple-sources-for-applications-ui.md or original PR: #17108
@keithchong keithchong added the enhancement New feature or request label Mar 21, 2024
@keithchong keithchong self-assigned this Mar 21, 2024
@keithchong keithchong added the component:ui User interfaces bugs and enhancements label Mar 21, 2024
keithchong added a commit to keithchong/argo-cd that referenced this issue Mar 21, 2024
@keithchong
feat: Provide Edit support in Sources tab for multi-source app (argop…
11260d0 
…roj#17588)

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong mentioned this issue Mar 21, 2024
Closed
14 tasks
keithchong added a commit to keithchong/argo-cd that referenced this issue Mar 22, 2024
@keithchong
feat: Provide Edit support in Sources tab for multi-source app (argop…
ca36fa4 
…roj#17588)

Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong added a commit to keithchong/argo-cd that referenced this issue Mar 26, 2024
@keithchong
feat: Provide Edit support in Sources tab for multi-source app (argop…
422c6f6 
…roj#17588)

Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong added a commit to keithchong/argo-cd that referenced this issue Apr 17, 2024
@keithchong
feat: Provide Edit support in Sources tab for multi-source app (argop…
360a3b0 
…roj#17588)

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong linked a pull request Apr 18, 2024 that will close this issue
Open
14 tasks
keithchong added a commit to keithchong/argo-cd that referenced this issue Apr 23, 2024
@keithchong
feat: Provide Edit support in Sources tab for multi-source app (argop…
6bde7d9 
…roj#17588)

Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong added a commit to keithchong/argo-cd that referenced this issue Apr 23, 2024
@keithchong
feat: Provide Edit support in Sources tab for multi-source app (argop…
1b9ff88 
…roj#17588)

Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong added a commit to keithchong/argo-cd that referenced this issue Apr 24, 2024
@keithchong
feat: Provide Edit support in Sources tab for multi-source app (argop…
c699673 
…roj#17588)

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong mentioned this issue May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithchong keithchong

Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@keithchong