Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect comparison level displayed in the logs about refreshing app status: 825069003112 instead of 0-3 #18998

Closed
2 of 3 tasks
andrii-korotkov-verkada opened this issue Jul 9, 2024 · 0 comments · Fixed by #21298
Closed
2 of 3 tasks

Incorrect comparison level displayed in the logs about refreshing app status: 825069003112 instead of 0-3 #18998

andrii-korotkov-verkada opened this issue Jul 9, 2024 · 0 comments · Fixed by #21298
Labels
bug/in-triage This issue needs further triage to be correctly classified bug Something isn't working component:core Syncing, diffing, cluster state cache type:bug version:2.12 Latest confirmed affected version is 2.12

Comments

@andrii-korotkov-verkada
Copy link
Contributor

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

The logs which show refreshing app status and level sometimes show absurd value instead of value from 0 to 3, when controller refresh is requested. I wonder if it has something to do with ctrl.refreshRequestedApps[key] = compareWith.Max(ctrl.refreshRequestedApps[key]) where Max uses float64 and conversion back to CompareWith in its implementation.

To Reproduce

I don't know how, maybe just wait and it'd pop up eventually.

Expected behavior

The level is from 0 to 3.

Screenshots

Screenshot 2024-07-09 at 4 31 15 AM

Version

Using a custom build from master around 2024/07/07 + #18694 + #18972.

Logs

See the screenshot.
@andrii-korotkov-verkada andrii-korotkov-verkada added the bug Something isn't working label Jul 9, 2024
@alexmt alexmt added bug/in-triage This issue needs further triage to be correctly classified component:core Syncing, diffing, cluster state cache type:bug labels Jul 9, 2024
@andrii-korotkov-verkada andrii-korotkov-verkada added the version:2.12 Latest confirmed affected version is 2.12 label Nov 11, 2024
@shenxn shenxn mentioned this issue Dec 23, 2024
Merged
14 tasks
dudo pushed a commit to dudo/argo-cd that referenced this issue Jan 18, 2025
@shenxn @dudo
fix: correctly set compareWith when requesting app refresh with delay (…

Verified

This commit was signed with the committer’s verified signature.
dudo Brett Dudo
GPG key ID: 0ABED0BBABA0FAA0
Verified
Learn about vigilant mode
e02d351 
…fixes argoproj#18998) (argoproj#21298)

* fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen <s@sxn.dev>

* test: add UT

Signed-off-by: Xiaonan Shen <s@sxn.dev>

---------

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this issue Jan 20, 2025
@shenxn @revitalbarletz
fix: correctly set compareWith when requesting app refresh with delay (…
a5385b3 
…fixes argoproj#18998) (argoproj#21298)

* fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen <s@sxn.dev>

* test: add UT

Signed-off-by: Xiaonan Shen <s@sxn.dev>

---------

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
flbla pushed a commit to flbla/argo-cd that referenced this issue Jan 20, 2025
@shenxn @flbla
fix: correctly set compareWith when requesting app refresh with delay (…
7cbce91 
…fixes argoproj#18998) (argoproj#21298)

* fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen <s@sxn.dev>

* test: add UT

Signed-off-by: Xiaonan Shen <s@sxn.dev>

---------

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
Signed-off-by: flbla <flbla@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Feb 23, 2025
@shenxn
fix: correctly set compareWith when requesting app refresh with delay (…
Loading
Loading status checks…
7b5a1fe 
…fixes #18998) (#21298)

* fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen <s@sxn.dev>

* test: add UT

Signed-off-by: Xiaonan Shen <s@sxn.dev>

---------

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Feb 23, 2025
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Feb 23, 2025
@shenxn
fix: correctly set compareWith when requesting app refresh with delay (…
Loading
Loading status checks…
88ab10d 
…fixes #18998) (#21298)

* fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen <s@sxn.dev>

* test: add UT

Signed-off-by: Xiaonan Shen <s@sxn.dev>

---------

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Feb 23, 2025
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Feb 23, 2025
@shenxn
fix: correctly set compareWith when requesting app refresh with delay (…
Loading
Loading status checks…
f4a5da8 
…fixes #18998) (#21298)

* fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen <s@sxn.dev>

* test: add UT

Signed-off-by: Xiaonan Shen <s@sxn.dev>

---------

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Feb 23, 2025
Merged
gdsoumya pushed a commit that referenced this issue Feb 23, 2025
@gcp-cherry-pick-bot @shenxn
fix: correctly set compareWith when requesting app refresh with delay (…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
92a3c3d 
…fixes #18998) (cherry-pick #21298) (#21952)

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
gdsoumya pushed a commit that referenced this issue Feb 23, 2025
@gcp-cherry-pick-bot @shenxn
fix: correctly set compareWith when requesting app refresh with delay (…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c7937f1 
…fixes #18998) (cherry-pick #21298) (#21953)

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
gdsoumya pushed a commit that referenced this issue Feb 23, 2025
@gcp-cherry-pick-bot @shenxn
fix: correctly set compareWith when requesting app refresh with delay (…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
61a1c74 
…fixes #18998) (cherry-pick #21298) (#21954)

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
vasilegroza pushed a commit to vasilegroza/argo-cd that referenced this issue Feb 27, 2025
@shenxn @vasilegroza
fix: correctly set compareWith when requesting app refresh with delay (…
a210795 
…fixes argoproj#18998) (argoproj#21298)

* fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen <s@sxn.dev>

* test: add UT

Signed-off-by: Xiaonan Shen <s@sxn.dev>

---------

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/in-triage This issue needs further triage to be correctly classified bug Something isn't working component:core Syncing, diffing, cluster state cache type:bug version:2.12 Latest confirmed affected version is 2.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly set compareWith when requesting app refresh with delay (fixes #18998) shenxn/argo-cd
2 participants
@alexmt @andrii-korotkov-verkada