feat: add ARGOCD_APP_REVISION_SHORT_8 variable in build environment #16293 #19931
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Falanty
force-pushed
the
issue-16293
branch
5 times, most recently
from
55f68bb to
4286dea
Compare
Signed-off-by: Adam, Patrick <p.adam@mail.de>
Falanty
force-pushed
the
issue-16293
branch
from
4286dea to
d0ac070
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19931 +/- ##
==========================================
+ Coverage 55.81% 55.83% +0.02%
==========================================
Files 320 320
Lines 44378 44382 +4
==========================================
+ Hits 24769 24781 +12
+ Misses 17046 17031 -15
- Partials 2563 2570 +7 ☔ View full report in Codecov by Sentry. |
nitishfy
approved these changes
Sep 16, 2024
reggie-k
approved these changes
Sep 16, 2024
pasha-codefresh
approved these changes
Sep 17, 2024
|
when will it be released? |
|
This will be a part of the 2.14 release. |
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…rgoproj#19931) Signed-off-by: Adam, Patrick <p.adam@mail.de> Co-authored-by: Adam, Patrick <p.adam@mail.de> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16293
This feature adds a variable to the build environment, that contains the revision in short form with 8 characters. This complies with Gitlab's short sha.
While this solution diverges from the way short revisions are named in the SCM Provider Generator, it was chosen, because it is a non-breaking change.
Checklist: