Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Fix appset generate in --core mode #20717

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix(cli): Fix appset generate in --core mode #20717

merged 2 commits into from
Nov 21, 2024
+11 −3

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Nov 8, 2024 •
edited
Loading

Fixes #20692

I'd like it to be cherry-picked to 2.13.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Sorry, something went wrong.

@OpenGuidou
fix(cli): Fix appset generate in --core mode

Verified

This commit was signed with the committer’s verified signature.
OpenGuidou
GPG key ID: A4CE3AE990C72C9C
Verified
Learn about vigilant mode
Loading
Loading status checks…
549a254 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
@OpenGuidou OpenGuidou requested a review from a team as a code owner November 8, 2024 09:56
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 8, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@speedfl
Copy link
Contributor

speedfl commented Nov 8, 2024

LGTM

@speedfl speedfl self-assigned this Nov 8, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.16%. Comparing base (993d79c) to head (8de96ed).
Report is 385 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/headless/headless.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20717      +/-   ##
==========================================
- Coverage   55.21%   55.16%   -0.05%     
==========================================
  Files         324      324              
  Lines       55256    55263       +7     
==========================================
- Hits        30508    30485      -23     
- Misses      22133    22160      +27     
- Partials     2615     2618       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrii-korotkov-verkada
andrii-korotkov-verkada reviewed Nov 9, 2024
View reviewed changes
cmd/argocd/commands/headless/headless.go
@@ -237,7 +238,14 @@ func MaybeStartLocalServer(ctx context.Context, clientOpts *apiclient.ClientOpti
return fmt.Errorf("error creating kubernetes dynamic clientset: %w", err)
}

controllerClientset, err := client.New(restConfig, client.Options{})
scheme := runtime.NewScheme()
err = v1alpha1.AddToScheme(scheme)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to do this? This seems like something that should be done automatically on some init.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed in the headless mode, when login with the --core option.
On this case you use this local api server and not the real remote one.
It's not required in the regular mode

@OpenGuidou
Merge branch 'master' into appsetgen

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
8de96ed
@ishitasequeira ishitasequeira merged commit 2c2e669 into argoproj:master Nov 21, 2024
32 checks passed
@OpenGuidou
Copy link
Contributor Author

/cherry-pick release-2.13

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@OpenGuidou
fix(cli): Fix appset generate in --core mode (#20717)
Loading
Loading status checks…
f305d84 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Nov 21, 2024
Merged
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Nov 21, 2024
@OpenGuidou
fix(cli): Fix appset generate in --core mode (argoproj#20717)
e6effdd 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
ishitasequeira pushed a commit that referenced this pull request Nov 21, 2024
@gcp-cherry-pick-bot @OpenGuidou
fix(cli): Fix appset generate in --core mode (#20717) (#20883)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ad36916 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Co-authored-by: OpenGuidou <73480729+OpenGuidou@users.noreply.github.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@OpenGuidou @adriananeci
fix(cli): Fix appset generate in --core mode (argoproj#20717)
9df52bb 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
@OpenGuidou OpenGuidou deleted the appsetgen branch December 9, 2024 09:57
@OpenGuidou OpenGuidou mentioned this pull request Dec 13, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira

@andrii-korotkov-verkada andrii-korotkov-verkada

Assignees

@speedfl speedfl

Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

argocd appset generate doesn't work when login with --core
4 participants
@OpenGuidou @speedfl @ishitasequeira @andrii-korotkov-verkada