fix(appset): events not honouring configured namespaces (#21219)

[eadred]

Namespace filtering is applied to Update, Delete and Generic events.

Fixes #21219

If possible I would like this fix also cherry-picked to 2.13 please.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[crenshaw-dev]

Change makes sense to me! Could you write a test?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.25%. Comparing base (d23e6ac) to head (b51241f).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21241      +/-   ##
==========================================
+ Coverage   53.35%   55.25%   +1.89%     
==========================================
  Files         337      337              
  Lines       56846    56845       -1     
==========================================
+ Hits        30330    31407    +1077     
+ Misses      23876    22744    -1132     
- Partials     2640     2694      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eadred]

I'm not quite sure what the failing unit test has to do with these changes.

[eadred]

PR #21271 attempts to fix the unrelated data race test failures.

[eadred]

Hi @crenshaw-dev - would you be able to re-review this please?

[agaudreault]

LGTM. Please resolve conflicts, I think another PR also modified the predicated, so the merge might required more testing.

[eadred]

@agaudreault I've merged. The conflicts were just because two new tests were trying to occupy the same space in the tests file. The predicate I've changed hasn't been modified on master since my branch was created - there's a new predicate, ignoreWhenAnnotationApplicationSetRefreshIsRemoved which has been added.

[eadred]

Also would it be possible for this fix to be cherry-picked to 2.13 please?

[crenshaw-dev]

/cherry-pick release-2.14

[crenshaw-dev]

/cherry-pick release-2.13

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error e852142fb9467d32cd580b633e744d34bd875adf into temp-cherry-pick-cc1f5b-release-2.14

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error e852142fb9467d32cd580b633e744d34bd875adf into temp-cherry-pick-cc1f5b-release-2.13

[crenshaw-dev]

@eadred can you open manual cherry-picks against 2.14, 2.13, 2.12, and 2.11 (or as far back as the bug exists within those supported releases)?

[eadred]

@crenshaw-dev This may be a stupid question, but do you just mean (for example for 2.14)?:

• In my fork branch off the release-2.14 branch
• Cherry-pick this fix onto that branch
• Raise a PR with target branch release-2.14

Or is there some alternative process?

[crenshaw-dev]

@eadred that's basically it! Only caveat I'd add is that I'd create a new branch based off release-2.14 (etc.) before cherry-picking, just so you have a clean release-2.14 branch in case you need it again later.

[eadred]

Cherry-pick MRs are:

• 2.14: fix(appset): events not honouring configured namespaces (#21219) #21519
• 2.13: fix(appset): events not honouring configured namespaces (#21219) #21520
• 2.12: fix(appset): events not honouring configured namespaces (#21219) #21521
• 2.11: fix(appset): events not honouring configured namespaces (#21219) #21522

[eadred]

@crenshaw-dev In all four of the cherry-pick PRs above the Check changes to generated code (pull_request) job is failing, but only because the logic in hack/update-manifests.sh (executed by codegen-local) isn't inferring IMAGE_TAG correctly, given my branch isn't called release-*. As a result all the appearances of the ArgoCD image tag in the generated Kubernetes manifests are showing diffs.