fix: correctly set compareWith when requesting app refresh with delay (fixes #18998) #21298
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaonan Shen <s@sxn.dev>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
shenxn
force-pushed
the
fix-request-app-refresh-with-delay
branch
from
db80633 to
54b7010
Compare
Signed-off-by: Xiaonan Shen <s@sxn.dev>
shenxn
force-pushed
the
fix-request-app-refresh-with-delay
branch
from
54b7010 to
540664d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21298 +/- ##
==========================================
- Coverage 55.23% 55.22% -0.01%
==========================================
Files 337 337
Lines 57055 57055
==========================================
- Hits 31515 31510 -5
- Misses 22847 22854 +7
+ Partials 2693 2691 -2 ☔ View full report in Codecov by Sentry. |
andrii-korotkov-verkada
approved these changes
Dec 29, 2024
bashlion
approved these changes
Jan 4, 2025
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
…fixes argoproj#18998) (argoproj#21298) * fix: correctly set compareWith when requesting app refresh with delay Signed-off-by: Xiaonan Shen <s@sxn.dev> * test: add UT Signed-off-by: Xiaonan Shen <s@sxn.dev> --------- Signed-off-by: Xiaonan Shen <s@sxn.dev> Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local> Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
…fixes argoproj#18998) (argoproj#21298) * fix: correctly set compareWith when requesting app refresh with delay Signed-off-by: Xiaonan Shen <s@sxn.dev> * test: add UT Signed-off-by: Xiaonan Shen <s@sxn.dev> --------- Signed-off-by: Xiaonan Shen <s@sxn.dev> Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
flbla
pushed a commit
to flbla/argo-cd
that referenced
this pull request
Jan 20, 2025
…fixes argoproj#18998) (argoproj#21298) * fix: correctly set compareWith when requesting app refresh with delay Signed-off-by: Xiaonan Shen <s@sxn.dev> * test: add UT Signed-off-by: Xiaonan Shen <s@sxn.dev> --------- Signed-off-by: Xiaonan Shen <s@sxn.dev> Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local> Signed-off-by: flbla <flbla@users.noreply.github.com>
|
/cherry-pick release-2.14 |
|
/cherry-pick release-2.13 |
|
/cherry-pick release-2.12 |
vasilegroza
pushed a commit
to vasilegroza/argo-cd
that referenced
this pull request
Feb 27, 2025
…fixes argoproj#18998) (argoproj#21298) * fix: correctly set compareWith when requesting app refresh with delay Signed-off-by: Xiaonan Shen <s@sxn.dev> * test: add UT Signed-off-by: Xiaonan Shen <s@sxn.dev> --------- Signed-off-by: Xiaonan Shen <s@sxn.dev> Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18998. When requesting app refresh with a delay, the request will be stored as a string in the form of
<appKey>/<compareWith>. However, the address ofcompareWithis used instead of its value, causing invalid refresh levels being used.Checklist: