fix(controller): rename cluster batch param and add to argocd-cmd-params-cm #21402
+158
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ams-cm Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
@mpelekh would you mind reviewing? |
mpelekh
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
The code looks good to me! Thank you, @crenshaw-dev, for making these changes!
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21402 +/- ##
==========================================
+ Coverage 55.21% 55.24% +0.03%
==========================================
Files 337 337
Lines 56945 56945
==========================================
+ Hits 31441 31460 +19
+ Misses 22828 22810 -18
+ Partials 2676 2675 -1 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-2.14 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
…ams-cm (#21402) * fix(controller): rename cluster batch param and add to argocd-cmd-params-cm Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * parameterize deployment too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * consistency Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jan 8, 2025
…ams-cm (#21402) (#21419) * fix(controller): rename cluster batch param and add to argocd-cmd-params-cm * parameterize deployment too * consistency --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
…ams-cm (argoproj#21402) * fix(controller): rename cluster batch param and add to argocd-cmd-params-cm Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * parameterize deployment too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * consistency Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
…ams-cm (argoproj#21402) * fix(controller): rename cluster batch param and add to argocd-cmd-params-cm Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * parameterize deployment too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * consistency Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
flbla
pushed a commit
to flbla/argo-cd
that referenced
this pull request
Jan 20, 2025
…ams-cm (argoproj#21402) * fix(controller): rename cluster batch param and add to argocd-cmd-params-cm Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * parameterize deployment too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * consistency Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: flbla <flbla@users.noreply.github.com>
vasilegroza
pushed a commit
to vasilegroza/argo-cd
that referenced
this pull request
Feb 27, 2025
…ams-cm (argoproj#21402) * fix(controller): rename cluster batch param and add to argocd-cmd-params-cm Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * parameterize deployment too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * consistency Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed an env var for consistency. This is a new feature in 2.14, so should be reasonably safe to change the var name.
Made the param configurable via argocd-cmd-params-cm.