Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make codegen permissions #21667

Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix: make codegen permissions #21667

merged 3 commits into from
Feb 10, 2025
+3 −1

Conversation

dudo
Copy link
Contributor

@dudo dudo commented Jan 25, 2025 •
edited
Loading

Fixes #21623

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Sorry, something went wrong.

@dudo dudo requested a review from a team as a code owner January 25, 2025 04:54
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jan 25, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@dudo
chown /go dirs

Verified

This commit was signed with the committer’s verified signature.
dudo Brett Dudo
GPG key ID: 0ABED0BBABA0FAA0
Verified
Learn about vigilant mode
Loading
Loading status checks…
4435469 
Signed-off-by: Brett C. Dudo <brett@dudo.io>
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (fa747f9) to head (1793e23).
Report is 11 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21667      +/-   ##
==========================================
- Coverage   55.67%   55.63%   -0.05%     
==========================================
  Files         339      339              
  Lines       56814    56814              
==========================================
- Hits        31634    31611      -23     
- Misses      22535    22548      +13     
- Partials     2645     2655      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rumstead
rumstead approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@rumstead rumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dudo and others added 2 commits February 5, 2025 19:44
@dudo @ishitasequeira
Update test/container/Dockerfile

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
11f7555 
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Brett Dudo <brett@dudo.io>
@dudo
Merge branch 'master' into fix_docker_test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1793e23
@ishitasequeira ishitasequeira merged commit b600c5e into argoproj:master Feb 10, 2025
32 checks passed
Sriteja-Tadakaluru pushed a commit to Sriteja-Tadakaluru/argo-cd that referenced this pull request Feb 16, 2025
@dudo @ishitasequeira
fix: make codegen permissions (argoproj#21667)
8fda8e4 
Signed-off-by: Brett C. Dudo <brett@dudo.io>
Signed-off-by: Brett Dudo <brett@dudo.io>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
chzar pushed a commit to chzar/argo-cd that referenced this pull request Mar 3, 2025
@dudo @ishitasequeira @chzar
fix: make codegen permissions (argoproj#21667)
64a46ed 
Signed-off-by: Brett C. Dudo <brett@dudo.io>
Signed-off-by: Brett Dudo <brett@dudo.io>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
@gdsoumya
Copy link
Member

gdsoumya commented Mar 4, 2025

/cherry-pick release-2.14

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 4, 2025
@dudo @ishitasequeira
fix: make codegen permissions (#21667)
Loading
Loading status checks…
b078a22 
Signed-off-by: Brett C. Dudo <brett@dudo.io>
Signed-off-by: Brett Dudo <brett@dudo.io>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Mar 4, 2025
Merged
gdsoumya pushed a commit that referenced this pull request Mar 4, 2025
@gcp-cherry-pick-bot @dudo @ishitasequeira
fix: make codegen permissions (cherry-pick #21667) (#22145)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
54170a4 
Signed-off-by: Brett C. Dudo <brett@dudo.io>
Signed-off-by: Brett Dudo <brett@dudo.io>
Co-authored-by: Brett Dudo <brett@dudo.io>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumstead rumstead

@ishitasequeira ishitasequeira

@andrii-korotkov-verkada andrii-korotkov-verkada

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make codegen fails with missing permissions on some environments
5 participants
@dudo @gdsoumya @rumstead @ishitasequeira @andrii-korotkov-verkada