fix(hydrator): refresh by annotation instead of work queue #22016
+33
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22016 +/- ##
==========================================
- Coverage 55.73% 53.55% -2.18%
==========================================
Files 342 342
Lines 57075 57111 +36
==========================================
- Hits 31809 30587 -1222
- Misses 22622 23925 +1303
+ Partials 2644 2599 -45 ☔ View full report in Codecov by Sentry. |
…-annotation Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
agaudreault
reviewed
Feb 27, 2025
agaudreault
reviewed
Feb 27, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
agaudreault
reviewed
Feb 27, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
agaudreault
approved these changes
Feb 27, 2025
|
/cherry-pick release-2.14 |
|
Cherry-pick failed with |
crenshaw-dev
added a commit
to crenshaw-dev/argo-cd
that referenced
this pull request
Feb 27, 2025
…22016) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-picking here: #22067 |
crenshaw-dev
added a commit
that referenced
this pull request
Feb 27, 2025
chzar
pushed a commit
to chzar/argo-cd
that referenced
this pull request
Mar 3, 2025
…22016) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
kingbj940429
pushed a commit
to kingbj940429/argo-cd
that referenced
this pull request
Mar 4, 2025
…22016) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22055
Instead of putting the app directly on the refresh queue, use the refresh annotation. This ensures that the correct controller shard picks up the refresh operation.