Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Generate crd from upstream #2614

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat(argo-cd): Generate crd from upstream #2614

wants to merge 5 commits into from
+37 −39

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Mar 29, 2024 •
edited

Closes #2613

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@DrFaust92 DrFaust92 changed the title Generate-crd Generate crd from upstream Mar 29, 2024
@DrFaust92
Copy link
Contributor Author

need to fix this to support the custom templating (annotations and if to enable crd) and this should be good. but i would love to get input from maintainer if this is a valid approach.

@jmeridth @pdrastil @yu-croco , what do you think?

@DrFaust92 DrFaust92 changed the title Generate crd from upstream feat(argo-cd): Generate crd from upstream Mar 29, 2024
@github-actions github-actions bot removed the size/L label Mar 29, 2024
@DrFaust92
generate crds from tag
7bc86fe 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
generate crds from tag
a47e458 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
generate crds from tag
c4f63af 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
generate crds from tag
92a22ac 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
generate crds from tag
2f56e90 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@yu-croco
Copy link
Collaborator

yu-croco commented Apr 2, 2024

Hi @DrFaust92 , thank you for your PR.
IMO:

  • Auto generation of CRD sounds nice to me.
  • In addition to support .Values.crds.xxxx , it's also nice to run this script when Renovate bumps version. 👍

@mbevc1 @mkilchhofer@jmeridth @pdrastil @tico24
WDYT? 🙋

@pdrastil
Copy link
Member

pdrastil commented Apr 3, 2024 •
edited

@yu-croco Sounds OK, however upstream do not have templating on CRD resources / additional conditional block we have. You can see removed sections in PR. In both cases auto-generation or manual sync I always have to modify these sections by hand.

@DrFaust92
Copy link
Contributor Author

@pdrastil I'll add logic to template this, just wanted to know if it's worth the effort in the first place 🤗

@pdrastil
Copy link
Member

pdrastil commented Apr 3, 2024

@DrFaust92 It is - my current process is doing diffs / manual copy & paste of spec based on upstream :)

@mkilchhofer
Copy link
Member

Maybe we need some yq logic to only copy over the CRD.spec?🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 will be requested when the pull request is marked ready for review mbevc1 is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer will be requested when the pull request is marked ready for review mkilchhofer is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco will be requested when the pull request is marked ready for review yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth will be requested when the pull request is marked ready for review jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil will be requested when the pull request is marked ready for review pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 will be requested when the pull request is marked ready for review tico24 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
argo-cd size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate CRD spec based on upstream tag, similar to kube-prometheus-stack helm chart
4 participants
@DrFaust92 @yu-croco @pdrastil @mkilchhofer