From c1c3a5a1fe47508da7bc2942dbee4763dccadcd6 Mon Sep 17 00:00:00 2001 From: toyamagu <83329336+toyamagu-2021@users.noreply.github.com> Date: Mon, 15 May 2023 23:18:17 +0900 Subject: [PATCH] fix: Parameter overwritten does not work when resubmitting archived workflow (#11086) (#11087) Signed-off-by: toyamagu2021@gmail.com --- server/workflowarchive/archived_workflow_server.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/workflowarchive/archived_workflow_server.go b/server/workflowarchive/archived_workflow_server.go index 0b23269bfe3a..3e0450ca9c58 100644 --- a/server/workflowarchive/archived_workflow_server.go +++ b/server/workflowarchive/archived_workflow_server.go @@ -262,7 +262,7 @@ func (w *archivedWorkflowServer) ResubmitArchivedWorkflow(ctx context.Context, r return nil, sutils.ToStatusError(err, codes.Internal) } - newWF, err := util.FormulateResubmitWorkflow(wf, req.Memoized, nil) + newWF, err := util.FormulateResubmitWorkflow(wf, req.Memoized, req.Parameters) if err != nil { return nil, sutils.ToStatusError(err, codes.Internal) } @@ -286,7 +286,7 @@ func (w *archivedWorkflowServer) RetryArchivedWorkflow(ctx context.Context, req _, err = wfClient.ArgoprojV1alpha1().Workflows(req.Namespace).Get(ctx, wf.Name, metav1.GetOptions{}) if apierr.IsNotFound(err) { - wf, podsToDelete, err := util.FormulateRetryWorkflow(ctx, wf, req.RestartSuccessful, req.NodeFieldSelector, nil) + wf, podsToDelete, err := util.FormulateRetryWorkflow(ctx, wf, req.RestartSuccessful, req.NodeFieldSelector, req.Parameters) if err != nil { return nil, sutils.ToStatusError(err, codes.Internal) }