Inline pods don't seem to generate a correct pod name that conforms to the standard naming convention #10912
Comments
|
According to the discussion on the slack it seems that it caused by |
|
Ok. This doesn't really explain the issue at all so I'll do so on your behalf. Slack discussion here: https://cloud-native.slack.com/archives/C01QW9QSSSK/p1681480509927789 inline pods don't seem to generate a correct pod name that conforms to the standard naming convention. As such, pod logs aren't viewable in the UI. So while the example above using inline doesn't allow the user to see pod logs, the equivelent using the more conventional template-driven dag does: apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
name: workflow-regular
namespace: argo
spec:
entrypoint: entrypoint
templates:
- name: entrypoint
dag:
tasks:
- name: notinline
template: notinline
- name: notinline
container:
name: inline
image: alpine
command:
- /bin/sh
- -c
- |
echo "Hello World"Unfortunately I don't have permissions to make the title of this issue more useful. |
n9
changed the title
|
The Containers tab is also empty:
|
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
|
@terrytangyuan the pods spawned for inline script still have My task body looks like this: - name: execute-workflow
inline:
inputs:
artifacts:
- name: manifest
path: /tmp/manifest.yaml
outputs: {}
metadata: {}
resource:
action: create
manifestFrom:
artifact:
name: manifest
setOwnerReference: true
successCondition: status.phase == Succeeded
failureCondition: status.phase in (Failed, Error) |
…rgoproj#10921) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
|
mmh maybe correct me if I am wrong, but if I read the fix PR it looks like you just added an if-statement what happens if the task is being named something with spec:
entrypoint: entrypoint
templates:
- name: entrypoint
dag:
tasks:
- name: some-task
inline:
container: ...and spec:
entrypoint: entrypoint
templates:
- name: entrypoint
dag:
tasks:
- name: some-task
template: some-task
- name: some-task
container: ...Can you maybe have another look, if you can fix the inline syntax so that it creates the correct pod name? |
…rgoproj#10921) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Pre-requisites
:latestWhat happened/what you expected to happen?
Workflow creates a pod with name containing double
-. But it expects that the pod contains just one-.It is visible e.g. in logs:
Version
v3.4.7
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: