Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend enum input ignores default value #12896

Open
3 of 4 tasks
artem-zherdiev-ingio opened this issue Apr 5, 2024 · 0 comments
Open
3 of 4 tasks

Suspend enum input ignores default value #12896

artem-zherdiev-ingio opened this issue Apr 5, 2024 · 0 comments

Comments

@artem-zherdiev-ingio
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issue exists when I tested with :latest
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

Enum ignores default input values with suspend, users have to manually choose value everytime and it's not possible to see which value was as default. Outputs are also empty if not select value by hand.
image
image

Expectation: if suspend inputs have a default value, the enum has it prepopulated as well as regular input.

Version

v3.5.5

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: broken-enum
  namespace: workflows
spec:
  serviceAccountName: workflows-executor

  entrypoint: pipeline
  templates:
    - name: wait
      suspend:
        duration: '15m'
      inputs:
        parameters:
          - name: input
          - name: select
            enum:
              - default
              - option1
              - option2
              - option3
      outputs:
        parameters:
          - name: input
            valueFrom:
              supplied: {}
          - name: select
            valueFrom:
              supplied: {}

    - name: pipeline
      dag:
        tasks:
          - name: wait
            template: wait
            arguments:
              parameters:
                - name: input
                  value: default
                - name: select
                  value: default

Logs from the workflow controller

time="2024-04-05T12:35:24.738Z" level=info msg="Processing workflow" Phase= ResourceVersion=285746611 namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg="Task-result reconciliation" namespace=workflows numObjs=0 workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg="Updated phase  -> Running" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=warning msg="Node was nil, will be initialized as type Skipped" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg="was unable to obtain node for , letting display name to be nodeName" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg="DAG node broken-enum-w94q2 initialized Running" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=warning msg="was unable to obtain the node for broken-enum-w94q2-2533498415, taskName wait"
time="2024-04-05T12:35:24.768Z" level=warning msg="was unable to obtain the node for broken-enum-w94q2-2533498415, taskName wait"
time="2024-04-05T12:35:24.768Z" level=info msg="All of node broken-enum-w94q2.wait dependencies [] completed" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=warning msg="Node was nil, will be initialized as type Skipped" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg="Suspend node broken-enum-w94q2-2533498415 initialized Pending" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg="node broken-enum-w94q2.wait suspended" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg="node broken-enum-w94q2-2533498415 phase Pending -> Running" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg="TaskSet Reconciliation" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.768Z" level=info msg=reconcileAgentPod namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:24.780Z" level=info msg="Workflow update successful" namespace=workflows phase=Running resourceVersion=285746612 workflow=broken-enum-w94q2
time="2024-04-05T12:35:34.781Z" level=info msg="Processing workflow" Phase=Running ResourceVersion=285746612 namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:34.782Z" level=info msg="Task-result reconciliation" namespace=workflows numObjs=0 workflow=broken-enum-w94q2
time="2024-04-05T12:35:34.782Z" level=info msg="node broken-enum-w94q2.wait suspended" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:34.782Z" level=info msg="TaskSet Reconciliation" namespace=workflows workflow=broken-enum-w94q2
time="2024-04-05T12:35:34.782Z" level=info msg=reconcileAgentPod namespace=workflows workflow=broken-enum-w94q2

Logs from in your workflow's wait container

-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants