fix(test): ensure workflow has completed before check its phase. Fixes #12906 #12927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AlbeeSo <suyashi1321@163.com>
agilgur5
reviewed
Apr 18, 2024
| @@ -141,7 +141,7 @@ func (s *SignalsSuite) TestSignaled() { | |||
| Workflow("@testdata/signaled-workflow.yaml"). | |||
| When(). | |||
| SubmitWorkflow(). | |||
| WaitForWorkflow(). | |||
| WaitForWorkflow(fixtures.ToBeCompleted). | |||
There was a problem hiding this comment.
the default is ToBeDone, which is a subset of ToBeCompleted which should be equivalent in this case, so I wouldn't think this would change anything
agilgur5
added
type/tech-debt
problem/more information needed
|
This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs. |
github-actions
bot
added
the
problem/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12906
Motivation
TestSignaledandTestSignaledContainerSetfailed sometimes as check phase of a workflow before it is completed.Modifications
Use
fixtures.ToBeCompletedto ensure workflow has completed.Verification