Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSignaledContainerSet fail sometimes (flakey test) #12906

Open
4 tasks done
shuangkun opened this issue Apr 7, 2024 · 1 comment · May be fixed by #12927
Open
4 tasks done

TestSignaledContainerSet fail sometimes (flakey test) #12906

shuangkun opened this issue Apr 7, 2024 · 1 comment · May be fixed by #12927
Assignees
@shuangkun
Labels
area/build Build or GithubAction/CI issues type/bug type/tech-debt

Comments

@shuangkun
Copy link
Member

shuangkun commented Apr 7, 2024 •
edited by agilgur5

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issue exists when I tested with :latest
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

TestSignaledContainerSet failed

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

● example   Workflow  0s      
 └ ● example Pod       0s      
 └ ● two     Container 0s      
 └ ✖ one     Container 8s      OOMKilled (exit code 137): 

    signals_test.go:157: timeout after 1m30s waiting for condition
Checking expectation example
example : Running 
    signals_test.go:160: 
        	Error Trace:	/home/runner/work/argo-workflows/argo-workflows/test/e2e/signals_test.go:160
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:69
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:44
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/signals_test.go:159
        	Error:      	Not equal: 
        	            	expected: "Failed"
        	            	actual  : "Running"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-(v1alpha1.WorkflowPhase) (len=6) "Failed"
        	            	+(v1alpha1.WorkflowPhase) (len=7) "Running"
        	            	 
        	Test:       	TestSignalsSuite/TestSignaledContainerSet
    signals_test.go:161: 
        	Error Trace:	/home/runner/work/argo-workflows/argo-workflows/test/e2e/signals_test.go:161
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:69
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:44
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/signals_test.go:159
        	Error:      	"" does not contain "(exit code 137)"
        	Test:       	TestSignalsSuite/TestSignaledContainerSet
    signals_test.go:169: 
        	Error Trace:	/home/runner/work/argo-workflows/argo-workflows/test/e2e/signals_test.go:169
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:69
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:44
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/signals_test.go:159
        	Error:      	Not equal: 
        	            	expected: "Failed"
        	            	actual  : "Running"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-(v1alpha1.NodePhase) (len=6) "Failed"
        	            	+(v1alpha1.NodePhase) (len=7) "Running"
        	            	 
        	Test:       	TestSignalsSuite/TestSignaledContainerSet
    signals_test.go:170: 
        	Error Trace:	/home/runner/work/argo-workflows/argo-workflows/test/e2e/signals_test.go:170
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:69
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/fixtures/then.go:44
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/signals_test.go:159
        	Error:      	"" does not contain "(exit code 143)"
        	Test:       	TestSignalsSuite/TestSignaledContainerSet
=== FAIL: SignalsSuite/TestSignaledContainerSet

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
@shuangkun shuangkun self-assigned this Apr 7, 2024
@shuangkun
Copy link
Member Author

https://github.com/argoproj/argo-workflows/actions/runs/8585303307/job/23526604192?pr=12817

@shuangkun shuangkun changed the title TestSignaledContainerSet failed TestSignaledContainerSet fail sometimes (flakey test) Apr 7, 2024
@agilgur5 agilgur5 added type/tech-debt area/build Build or GithubAction/CI issues labels Apr 8, 2024
@AlbeeSo AlbeeSo linked a pull request Apr 11, 2024 that will close this issue
Open
@miltalex miltalex mentioned this issue Apr 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuangkun shuangkun

Labels
area/build Build or GithubAction/CI issues type/bug type/tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): ensure workflow has completed before check its phase. Fixes #12906 AlbeeSo/argo-workflows
2 participants
@agilgur5 @shuangkun