Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Copy from workflow logs using Ctrl-C doesn't work #12947

Open
4 tasks done
Joibel opened this issue Apr 16, 2024 · 3 comments
Open
4 tasks done

UI: Copy from workflow logs using Ctrl-C doesn't work #12947

Joibel opened this issue Apr 16, 2024 · 3 comments
Assignees
Labels
area/ui area/upstream This is an issue with an upstream dependency, not Argo itself P3 Low priority solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/bug

Comments

@Joibel
Copy link
Member

Joibel commented Apr 16, 2024

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issue exists when I tested with :latest
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

This is a reproduction on firefox 124.0.2 on linux/gnome/wayland of a bug report from windows. I have reproduced it using other window managers and browsers on linux too. I have been informed this works fine on MacOS, which may be down to copy being Cmd+C rather than Ctrl-C there.

In pod logs in the user interface is it not possible to use Ctrl-C to copy the logs. This is demonstrated here:

https://drive.google.com/file/d/1PGk6Y7RRyvg4vppxuhpJUYcjubYf-A91/view?usp=drive_link

Right click copy works.

Version

v3.5.5

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

Not relevant

Logs from the workflow controller

Not relevant

Logs from in your workflow's wait container

Not relevant
@Joibel
Copy link
Member Author

Joibel commented Apr 16, 2024

Tagging @Adrien-D to work on it

@Joibel Joibel changed the title Copy from workflow logs using Ctrl-C doesn't work UI: Copy from workflow logs using Ctrl-C doesn't work Apr 16, 2024
@agilgur5
Copy link
Member

I have been informed this works fine on MacOS, which may be down to copy being Cmd+C rather than Ctrl-C there.

Can confirm, works fine on my Mac

Right click copy works.

This would suggest that Ctrl is being captured by something and not handled, since copying still works and Cmd+C works on Mac. I don't believe we have any such code in this part of the UI, so I would wonder if this might be upstream in xterm

@agilgur5 agilgur5 added the P3 Low priority label Apr 16, 2024
@agilgur5
Copy link
Member

so I would wonder if this might be upstream in xterm

We're also on an older version of xterm, so probably first thing I would recommend is upgrading it

@agilgur5 agilgur5 added solution/suggested A solution to the bug has been suggested. Someone needs to implement it. area/upstream This is an issue with an upstream dependency, not Argo itself labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui area/upstream This is an issue with an upstream dependency, not Argo itself P3 Low priority solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/bug
Projects
None yet
Development

No branches or pull requests

2 participants