Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent health status values #230

Open
jsoref opened this issue Feb 26, 2021 · 0 comments · May be fixed by #231
Open

Inconsistent health status values #230

jsoref opened this issue Feb 26, 2021 · 0 comments · May be fixed by #231

Comments

@jsoref
Copy link
Member

jsoref commented Feb 26, 2021

My preference is to capitalize the first letter and omit the trailing ...

return &HealthStatus{
Status: HealthStatusProgressing,
Message: "Waiting for statefulset spec update to be observed...",

return &HealthStatus{
Status: HealthStatusHealthy,
Message: fmt.Sprintf("partitioned roll out complete: %d new pods have been updated...", sts.Status.UpdatedReplicas),

if sts.Spec.UpdateStrategy.Type == appsv1.OnDeleteStatefulSetStrategyType {
return &HealthStatus{
Status: HealthStatusHealthy,
Message: fmt.Sprintf("statefulset has %d ready pods", sts.Status.ReadyReplicas),

return &HealthStatus{
Status: HealthStatusHealthy,
Message: fmt.Sprintf("statefulset rolling update complete %d pods at revision %s...", sts.Status.CurrentReplicas, sts.Status.CurrentRevision),

return &HealthStatus{
Status: HealthStatusHealthy,
Message: fmt.Sprintf("partitioned roll out complete: %d new pods have been updated...", sts.Status.UpdatedReplicas),

jsoref added a commit to jsoref/gitops-engine that referenced this issue Feb 26, 2021
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref jsoref linked a pull request Feb 26, 2021 that will close this issue
jsoref added a commit to jsoref/gitops-engine that referenced this issue Feb 26, 2021
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant