Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Passive #60

Open
mdstevens044 opened this issue May 14, 2020 · 4 comments
Open

Passive #60

mdstevens044 opened this issue May 14, 2020 · 4 comments
Labels
enhancement

Comments

@mdstevens044
Copy link

Is it possible to make events passive? Running lighthouse and getting dinged for event handler not being passive.
@arkon
Copy link
Owner

arkon commented Jul 30, 2020

It is possible to add. A PR would be welcomed.

@mdstevens044
Copy link
Author

Okay I have only done 1 PR before so I will try and see if I can figure it out again. I believe you just have to make the addEventListener's passive.

@mdstevens044
Copy link
Author

Do you have a contribution guide anywhere. Never created an npm module before so not sure how to bundle it once I make changes?

@arkon
Copy link
Owner

arkon commented Aug 7, 2020

Do you have a contribution guide anywhere.

I don't. You can refer to the scripts within package.json. You can also test it with the demo app in /demo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arkon @mdstevens044