Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated total_count option from paginated List struct #540

Open
belyakov-am opened this issue Apr 19, 2024 · 0 comments
Open

Remove deprecated total_count option from paginated List struct #540

belyakov-am opened this issue Apr 19, 2024 · 0 comments

Comments

@belyakov-am
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently List for pagination response has total_count field which is not supported by Stripe API for a while.
When I saw this field, I assumed it's populated by the API (despite being Option) and found out that it's outdated only during testing.

https://github.com/arlyon/async-stripe/blob/master/src/params.rs#L284-L293

Describe the solution you'd like

Ideal solution would be to just remove it

Describe alternatives you've considered

Another okayish way is to at least put a comment mentioning that this field shouldn't be used

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant