Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Analysis from home page #2595

Merged
merged 3 commits into from Jan 17, 2022
Merged

Link Analysis from home page #2595

merged 3 commits into from Jan 17, 2022

Conversation

serras
Copy link
Member

@serras serras commented Dec 15, 2021

This tracks the progress of replacing Meta in the main page with Analysis:

  • Replace links and code blocks to Analysis
  • Add arrow-analysis-lines and arrow-analysis-lines-white versions of the SVGs in arrow-site/docs/img/home (temporarily using color for everything)

@serras serras force-pushed the docs-analysis branch 2 times, most recently from 16a65c2 to 96259f7 Compare December 23, 2021 10:32
@serras serras force-pushed the docs-analysis branch 2 times, most recently from 9b2d6ee to 7241354 Compare January 12, 2022 08:59
@serras serras marked this pull request as ready for review January 13, 2022 09:39
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @serras !

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @serras !

Comment on lines +29 to +37
// maps to 'Employee' in parallel using 'parZip'
val audrey = parZip({ "Audrey" }, { company("Arrow") }) {
name, company -> Employee(name, company)
}
val pepe = parZip({ "Pepe" }, { company("Arrow") }) {
name, company -> Employee(name, company)
}
// hires in parallel using 'parTraverse'
return listOf(audrey, pepe).parTraverse { hire(it) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check how this affects the website.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked locally, and this snippet fits exactly the side of the code block, without any scroll bars (horizontal or vertical).

Copy link
Member

@nomisRev nomisRev Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for checking @serras!!

@nomisRev nomisRev merged commit 15c1e17 into main Jan 17, 2022
@nomisRev nomisRev deleted the docs-analysis branch January 17, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants