Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block style #2596

Merged
merged 2 commits into from Dec 17, 2021
Merged

Code block style #2596

merged 2 commits into from Dec 17, 2021

Conversation

israelperezglez
Copy link
Contributor

@Could you review this PR please? ;)

@israelperezglez
Copy link
Contributor Author

Attached is a screenshot of what the code snippet would look like. I had to create a horizontal and vertical bar, because of the size of the code.
Captura de pantalla 2021-12-15 a las 17 15 50

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @israelperezglez !

@nomisRev
Copy link
Member

We can try improving these snippets by using Knit include imports, right?
Or snippet specific <!--- INCLUDE --> that way you can get rid of the unwanted imports, or any other snippet setup.

@nomisRev
Copy link
Member

@israelperezglez @franciscodr I updated the snippets to look like the old ones using KotlinX Knit INCLUDE comments.

cc\ @raulraja @JavierSegoviaCordoba I don't think KotlinX Knit is running on the code snippets in the arrow-site project.

@rafaparadela
Copy link
Contributor

Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nomisRev nomisRev merged commit 1e9e23a into main Dec 17, 2021
@nomisRev nomisRev deleted the ip-review-code branch December 17, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants