Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to kotlinx-coroutines 1.6.0 #2606

Merged
merged 5 commits into from Dec 23, 2021
Merged

Upgrade to kotlinx-coroutines 1.6.0 #2606

merged 5 commits into from Dec 23, 2021

Conversation

serras
Copy link
Member

@serras serras commented Dec 22, 2021

No description provided.

@nomisRev
Copy link
Member

nomisRev commented Dec 22, 2021

Red 😕

@nomisRev
Copy link
Member

@serras I'm actually not sure if the broken test was regression, or faulty on our end..
I rewrote the test, and this makes a lot more sense to me and the behavior is correct. What do you think?

cc\ @raulraja

@nomisRev
Copy link
Member

I can try rewriting this tomorrow to a simple exampel share it on Kotlin Slack with the KotinX maintainers.

@serras
Copy link
Member Author

serras commented Dec 22, 2021

Red 😕

Yep, my intention was to make it easy to collaborate in this. I managed to fix the compilation problems, but some of the problems with tests are a bit out of my league.

@nomisRev nomisRev marked this pull request as ready for review December 23, 2021 09:10
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @serras @nomisRev !

@nomisRev nomisRev merged commit a08a8dc into main Dec 23, 2021
@nomisRev nomisRev deleted the coroutines-1-6-0 branch December 23, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants