Update contributing guide with Knit #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
approved these changes
Jan 12, 2022
CONTRIBUTING.md
Outdated
Comment on lines
247
to
253
| ./gradlew apiDump | ||
| ./gradlew :arrow-core:apiDump |
There was a problem hiding this comment.
Is it not easier to just run apiDump in all projects?
There was a problem hiding this comment.
Maybe you're right... I just tested on a project without API changes.
The initial run of ./gradlew apiDump took 2 min 13 s on my MacBook.
All the subsequent runs take around 50-55 s, regardless if I run the task on all projects with ./gradlew apiDump or just one subproject with ./gradlew :arrow-core-retrofit:apiDump. This is because Gradle recognizes the task as up-to-date:
> Task :arrow-core-retrofit:compileKotlin UP-TO-DATE
> Task :arrow-core-retrofit:compileJava NO-SOURCE
> Task :arrow-core-retrofit:classes UP-TO-DATE
> Task :arrow-core-retrofit:apiBuild UP-TO-DATE
> Task :arrow-core-retrofit:apiDump UP-TO-DATE
So it's probably better to remove this remark 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small updates to the contributing guide:
ank)apiDumptask can be called only for changed subproject (no need to run it for the whole project when only suproject has changed).